Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Use decl_error in common runtime modules#796

Merged
bkchr merged 2 commits intomasterfrom
joe-use-declerror
Jan 23, 2020
Merged

Use decl_error in common runtime modules#796
bkchr merged 2 commits intomasterfrom
joe-use-declerror

Conversation

@joepetrowski
Copy link
Contributor

Replaces string error messages with decl_error macro throughout the runtime.

API change: Renames pub enum Error to pub enum ValidityError in the registrar module because (a) it keeps convention within decl_error and (b) it is more descriptive.

Closes #790

@joepetrowski joepetrowski added A0-please_review Pull request needs code review. B2-breaksapi labels Jan 23, 2020
@joepetrowski joepetrowski requested a review from bkchr January 23, 2020 20:25
@bkchr bkchr merged commit be7f00a into master Jan 23, 2020
@bkchr bkchr deleted the joe-use-declerror branch January 23, 2020 20:56
tomusdrw pushed a commit that referenced this pull request Mar 26, 2021
* Bump Substrate to version used by Polkadot (`5f056830`)

* Use `log` crate for runtime logging

See paritytech/substrate#8128 for more info.

* Stop using return value from `execute_block`

* Update test weight
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use decl_error in runtime

2 participants