Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@andresilva
Copy link
Contributor

Still want to do another update in this PR, keeping it in progress.

@andresilva andresilva added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jan 17, 2020
@andresilva andresilva requested review from bkchr and gavofyork January 17, 2020 14:07
@andresilva andresilva added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jan 17, 2020
@andresilva andresilva changed the title Update latest substrate polkadot-master v0.17.18: Update latest substrate Jan 17, 2020
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andresilva andresilva added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Jan 17, 2020
@andresilva
Copy link
Contributor Author

Don't merge yet. It compiles fine but crashes on startup due to conflicting tokio versions.

@andresilva
Copy link
Contributor Author

Please don't merge this yet. Still waiting to merge another PR in substrate.

@andresilva andresilva added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Jan 17, 2020
@andresilva andresilva merged commit fc100e6 into master Jan 17, 2020
@andresilva andresilva deleted the andre/update-substrate branch January 17, 2020 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants