add pallet_im_online::migration to Unreleased migrations

[melekes]

refs #7309 (comment)

[ggwpez]

CI try-runtime should turn green for Kusama and Westend.

[melekes]

[2023-06-16 12:42:53] 2023-06-16 12:42:53.375 ERROR main remote-ext: Error = Transport(Server returned an error status code: 404)    
[2023-06-16 12:42:53] Error: 
[2023-06-16 12:42:53]    0: Invalid input: rpc finalized_head failed.

does this mean there's an error in migration?

[ggwpez]

I asked in the CI/CD channel, but i think the node is down or something.

[melekes]

[2023-06-18 14:34:23] 2023-06-18 14:34:23.686 ERROR main runtime::configuration: Last PendingConfig is invalidity MaxCodeSizeExceedHardLimit { max_code_size: 10485760 }    
[2023-06-18 14:34:23] 2023-06-18 14:34:23.686  INFO main runtime::im-online::migration::v1: Migrating 26 received heartbeats    
[2023-06-18 14:34:23] 2023-06-18 14:34:23.687 ERROR main try-runtime: Detected multiple errors while executing `try_on_runtime_upgrade`:    
[2023-06-18 14:34:23] 2023-06-18 14:34:23.687 ERROR main try-runtime: Other("must upgrade linearly")    
[2023-06-18 14:34:23] 2023-06-18 14:34:23.687 ERROR main try-runtime: Other("Pending upgrade must be sane but was not")  

[2023-06-18 14:34:23] 2023-06-18 14:34:23.687  INFO main runtime::frame-support: ⚠️ XcmPallet declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)` 

[2023-06-18 14:34:23] 2023-06-18 14:34:23.687 ERROR main runtime: panicked at 'called `Result::unwrap()` on an `Err` value: Other("Detected multiple errors while executing `try_on_runtime_upgrade`, check the logs!")', /builds/parity/mirrors/polkadot/runtime/polkadot/src/lib.rs:2075:65

does this mean I should've set STORAGE_VERSION to 0 here https://github.com/paritytech/substrate/blob/ae1a608c91a5da441a0ee7c26a4d5d410713580d/frame/im-online/src/lib.rs#L255 ?

[bkchr]

does this mean I should've set STORAGE_VERSION to 0 here

No that is not the error. The error is this

ERROR main runtime::configuration: Last PendingConfig is invalidity MaxCodeSizeExceedHardLimit { max_code_size: 10485760

Which isn't your fault

[liamaharon]

Are there any blockers to merging this @melekes?

[melekes]

Are there any blockers to merging this @melekes?

broken CI #7387 (comment) ?

[ggwpez]

The polkadot try-runtime will not go green until https://polkadot.polkassembly.io/referenda/9 is enacted.
But Kusama and Westend look good.

[bkchr]

@melekes just let's merge master and then let's ignore the failing migration.

[melekes]

bot rebase

[paritytech-processbot]

Error: Command 'Command { std: cd "/storage/repositories/polkadot" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

[ggwpez]

The error in the Kusama society pallet is fixed here Society: On chain storage version StorageVersion(0) doesn't match current storage version StorageVersion(2).: paritytech/substrate#14421

[bkchr]

bot fmt

[command-bot]

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3066573 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 27-3294f378-c88f-449d-a0a0-8687e175846d to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3066573 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3066573/artifacts/download.