Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Additional tracing in provisioner, vote_selection and dispute-coordinator #6775

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Additional tracing in provisioner, vote_selection and dispute-coordinator #6775

merged 5 commits into from
Mar 6, 2023

Conversation

tdimitrov
Copy link
Contributor

@tdimitrov tdimitrov commented Feb 24, 2023 •
edited
Loading

Add some additional trace logs in provisioner and dispute-coordinator to make debugging easier.
Add new metric in dispute-coordinator - fetched_onchain_disputes. It measures how many disputes were fetched from the runtime by the dispute-coordinator.

@tdimitrov tdimitrov mentioned this pull request Feb 27, 2023
Closed
@tdimitrov
Some tracelines in dispute-coordinator
d139d3c 
TODO: cherry pick this in the initial branch!!!
@tdimitrov
Remove spammy logs
21407de
@tdimitrov tdimitrov changed the title Additional tracing in provisioner, vote_selection Additional tracing in provisioner, vote_selection and dispute-coordinator Mar 1, 2023
tdimitrov
tdimitrov commented Mar 1, 2023
View reviewed changes
node/core/provisioner/src/metrics.rs
@@ -36,6 +36,9 @@ struct MetricsInner {

/// The disputes received from `disputes-coordinator` by partition
partitioned_disputes: prometheus::CounterVec<prometheus::U64>,

/// The disputes fetched from the runtime.
fetched_onchain_disputes: prometheus::Counter<prometheus::U64>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metric didn't help much during the debugging. Should we keep it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it if it is not useful, we already have a ton of metrics, most of them we never use :)

@tdimitrov tdimitrov added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 1, 2023
@tdimitrov tdimitrov marked this pull request as ready for review March 1, 2023 08:49
sandreim
sandreim approved these changes Mar 1, 2023
View reviewed changes
node/core/provisioner/src/metrics.rs
@@ -36,6 +36,9 @@ struct MetricsInner {

/// The disputes received from `disputes-coordinator` by partition
partitioned_disputes: prometheus::CounterVec<prometheus::U64>,

/// The disputes fetched from the runtime.
fetched_onchain_disputes: prometheus::Counter<prometheus::U64>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove it if it is not useful, we already have a ton of metrics, most of them we never use :)

BradleyOlson64
BradleyOlson64 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@BradleyOlson64 BradleyOlson64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I think this serves as a good example for changes I may need to make in #6735

@tdimitrov
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 9d189f4 into master Mar 6, 2023
@paritytech-processbot paritytech-processbot bot deleted the tsv-provisioner-more-traces branch March 6, 2023 12:18
s0me0ne-unkn0wn pushed a commit that referenced this pull request Mar 6, 2023
@tdimitrov @s0me0ne-unkn0wn
Additional tracing in provisioner, vote_selection and `dispute-co…
cfc2faf 
…ordinator` (#6775)

* Additional tracing in `provisioner`, `vote_selection`

* Add `fetched_onchain_disputes` metric to provisioner

* Some tracelines in dispute-coordinator

TODO: cherry pick this in the initial branch!!!

* Remove spammy logs

* Remove some trace lines
ordian added a commit that referenced this pull request Mar 7, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
5046c2d 
* master: (27 commits)
  bump `zombienet` version to v1.3.37 (#6773)
  Bump `blake2b_simd` to 1.0.1 (#6829)
  changelog: update template for new label behavior (E3/E4) (#6804)
  Companion for paritytech/substrate#12828 (#6380)
  Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727)
  Polkadot XCM Body constants (#6788)
  Decrease expected peer count in zombinenet tests (#6826)
  Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)
  Change node-key for bootnodes (#6772)
  Change handle_import_statements to FatalResult (#6820)
  Introduce XCM matcher for writing barriers (#6756)
  Freeze note on `SessionInfo`. (#6818)
  Bump parity-db (#6816)
  Removing Outdated References to Misbehavior Arbitration Subsystem (#6814)
  Forgotten re-export for `MatchedConvertedConcreteId` (#6815)
  Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809)
  Migrate to `Weight::from_parts` (#6794)
  [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739)
  Get rid of unnecessary cloning and work. (#6808)
  changelog: fix migration listing (#6806)
  ...
ordian added a commit that referenced this pull request Mar 7, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
f2119e4 
* master: (27 commits)
  bump `zombienet` version to v1.3.37 (#6773)
  Bump `blake2b_simd` to 1.0.1 (#6829)
  changelog: update template for new label behavior (E3/E4) (#6804)
  Companion for paritytech/substrate#12828 (#6380)
  Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727)
  Polkadot XCM Body constants (#6788)
  Decrease expected peer count in zombinenet tests (#6826)
  Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)
  Change node-key for bootnodes (#6772)
  Change handle_import_statements to FatalResult (#6820)
  Introduce XCM matcher for writing barriers (#6756)
  Freeze note on `SessionInfo`. (#6818)
  Bump parity-db (#6816)
  Removing Outdated References to Misbehavior Arbitration Subsystem (#6814)
  Forgotten re-export for `MatchedConvertedConcreteId` (#6815)
  Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809)
  Migrate to `Weight::from_parts` (#6794)
  [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739)
  Get rid of unnecessary cloning and work. (#6808)
  changelog: fix migration listing (#6806)
  ...
paritytech-processbot bot pushed a commit that referenced this pull request Mar 8, 2023
@s0me0ne-unkn0wn @mrcnski
@BradleyOlson64 @pmensik @tdimitrov
Move PVF timeouts to executor environment parameters (#6823)
0122e14 
* Move PVF timeouts to executor environment parameters

* Typo

Co-authored-by: Marcin S. <[email protected]>

* Fix comments

* Change handle_import_statements to FatalResult (#6820)

* Changing dispute db errors to fatal

* fmt

* Change node-key for bootnodes (#6772)

* Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775)

* Additional tracing in `provisioner`, `vote_selection`

* Add `fetched_onchain_disputes` metric to provisioner

* Some tracelines in dispute-coordinator

TODO: cherry pick this in the initial branch!!!

* Remove spammy logs

* Remove some trace lines

* Rename and fix things

* Fix comments

* Typo

* Minor fixes

* Add codec indexes; Remove macro

---------

Co-authored-by: Marcin S. <[email protected]>
Co-authored-by: Bradley Olson <[email protected]>
Co-authored-by: Petr Mensik <[email protected]>
Co-authored-by: Tsvetomir Dimitrov <[email protected]>
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eskimor eskimor eskimor approved these changes

@BradleyOlson64 BradleyOlson64 BradleyOlson64 approved these changes

@sandreim sandreim sandreim approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdimitrov @eskimor @BradleyOlson64 @sandreim