This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix spending limits comments of gov2 origins#6310
Open
brenzi wants to merge 1 commit intoparitytech:masterfrom
Open
fix spending limits comments of gov2 origins#6310brenzi wants to merge 1 commit intoparitytech:masterfrom
brenzi wants to merge 1 commit intoparitytech:masterfrom
Conversation
paradox-tt
reviewed
Nov 21, 2022
paradox-tt
left a comment
paradox-tt
left a comment
There was a problem hiding this comment.
Happy to see someone else noticed the incorrect comments!
Just a suggestion that all units should remain the same (KSM) and there should be standard decimal places (3).
bkchr
added
A2-insubstantial
Member
|
Maybe we rather update the constants to be on-par with the comments. |
|
I wouldn't be comfortable altering these limits seeing that this is now live. Any changes to such limits should be done under some governance directive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes paritytech/polkadot-sdk#753