Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Let PR titles spread accross multiple lines in the release notes #5521

Merged
chevdor merged 1 commit into from
Jun 21, 2022
Merged

Let PR titles spread accross multiple lines in the release notes #5521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/ci/changelog/templates/change.md.tera
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@
{%- else -%}
{%- set xcm = "" -%}
{%- endif -%}
{{- repo }} {{ audit }}[`#{{c.number}}`]({{c.html_url}}) {{- prio }} - {{ c.title | capitalize | truncate(length=60, end="…") }}{{xcm }}
{{- repo }} {{ audit }}[`#{{c.number}}`]({{c.html_url}}) {{- prio }} - {{ c.title | capitalize | truncate(length=120, end="…") }}{{xcm }}
Copy link
Contributor

@dvdplm dvdplm Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have gone for wider still, 1024. :)

Copy link
Contributor Author

@chevdor chevdor Jul 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some of the releases notes and considering the GH width limit, the limits for a line seems to be around 88 chars left for the PR description. I would even set it to down to 80 to prevent the following:
image
(This is an extract of the draft for v0.9.26-rc2)

NOTE: No matter how big/wide is your screen, the width is set by the GH UI.

So I would go back lower :)

{%- endmacro change -%}