Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fix priority thresholds (backport #5375)#5376

Merged
chevdor merged 1 commit intorelease-v0.9.20from
wk-fix-release-notes-prio-backport
Apr 25, 2022
Merged

Fix priority thresholds (backport #5375)#5376
chevdor merged 1 commit intorelease-v0.9.20from
wk-fix-release-notes-prio-backport

Conversation

@chevdor
Copy link
Contributor

@chevdor chevdor commented Apr 22, 2022

backport #5375 for v0.9.20

@chevdor chevdor added A8-backport A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 22, 2022
@chevdor chevdor requested a review from coderobe April 22, 2022 09:57
@coderobe
Copy link
Contributor

Does this even require a backport? I think the github action uses the template off master anyway, no?

@chevdor
Copy link
Contributor Author

chevdor commented Apr 22, 2022

@coderobe I have had issues in the past thinking that too. If we don't backport, be aware of the risk that we need a manual check.

Copy link
Contributor

@coderobe coderobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can see if the drafts change after the PR targeting master is merged (there will be another RC anyway due to migration woes) and then decide to merge or not to merge this one into the release branch

@coderobe
Copy link
Contributor

seems like master wasn't enough

@chevdor chevdor merged commit 2723722 into release-v0.9.20 Apr 25, 2022
@chevdor chevdor deleted the wk-fix-release-notes-prio-backport branch April 25, 2022 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments