Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add mmr_root() to pallet-mmr API to expose root from state (companion for substrate#11183) #5276

Merged
paritytech-processbot merged 10 commits into from
Apr 13, 2022
Merged

Add mmr_root() to pallet-mmr API to expose root from state (companion for substrate#11183) #5276

paritytech-processbot merged 10 commits into from
Apr 13, 2022

Conversation

@acatangiu
Copy link
Contributor

@acatangiu acatangiu commented Apr 7, 2022 •
edited
Loading

Companion for paritytech/substrate#11183

Add mmr_root() to MmrApi (pallet-mmr).
Remove DepositBeefyDigest (which would add MMR roots to header digests) from Rococo.

Cumulus companion: paritytech/cumulus#1161

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Apr 7, 2022
@acatangiu acatangiu self-assigned this Apr 7, 2022
@acatangiu acatangiu mentioned this pull request Apr 7, 2022
Merged
@acatangiu acatangiu changed the title Add mmr_root() to pallet-mmr API to expose root from state Add mmr_root() to pallet-mmr API to expose root from state (companion for substrate#11183) Apr 8, 2022
@joao-paulo-parity joao-paulo-parity mentioned this pull request Apr 11, 2022
Closed
@paritytech-ci paritytech-ci requested review from a team April 11, 2022 12:01
@paritytech-ci paritytech-ci requested a review from a team April 11, 2022 20:50
@acatangiu acatangiu added the A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. label Apr 12, 2022
@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 13, 2022

Waiting for commit status.

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 13, 2022

Merge cancelled due to error. Error: Checks failed for b724666

@acatangiu
Copy link
Contributor Author

acatangiu commented Apr 13, 2022

bot merge

@paritytech-processbot
Copy link

paritytech-processbot bot commented Apr 13, 2022

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 4ca90b6 into paritytech:master Apr 13, 2022
@acatangiu acatangiu deleted the companion-mmr-root-api branch April 13, 2022 10:55
@joao-paulo-parity joao-paulo-parity mentioned this pull request Apr 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@antonio-dropulic antonio-dropulic Awaiting requested review from antonio-dropulic

4 more reviewers

@dvdplm dvdplm dvdplm approved these changes

@andresilva andresilva andresilva approved these changes

@svyatonik svyatonik svyatonik approved these changes

@rphmeier rphmeier rphmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@acatangiu acatangiu

Labels

A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@acatangiu @dvdplm @andresilva @svyatonik @rphmeier