This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[ci] don't exclude frame_system from weights benchmarks #5179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderobe
added
A0-please_review
ggwpez
approved these changes
Mar 22, 2022
EgorPopelyaev
approved these changes
Mar 22, 2022
chevdor
approved these changes
Mar 22, 2022
Member
|
Is it possible that it is excluded because it doesnt follow the pattern of other pallets? Since most pallets are It seems it should be specially handled in any case. |
Member
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while preparing the weights in #5097 i noticed that
frame_systembenchmarks are explicitly not ran by the default CI scripts, though i can't think of a good reason why - this change includes them again