This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate Slot Depositors in Crowdloan Migration#5173
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom Mar 30, 2022
Merged
Migrate Slot Depositors in Crowdloan Migration#5173paritytech-processbot[bot] merged 3 commits intomasterfrom
paritytech-processbot[bot] merged 3 commits intomasterfrom
Conversation
shawntabrizi
added
B7-runtimenoteworthy
C3-medium
emostov
reviewed
Mar 23, 2022
emostov
reviewed
Mar 23, 2022
| let account_info = frame_system::Account::<T>::take(old_fund_account); | ||
| frame_system::Account::<T>::insert(new_fund_account, account_info); | ||
| let account_info = frame_system::Account::<T>::take(&old_fund_account); | ||
| frame_system::Account::<T>::insert(&new_fund_account, account_info); |
Contributor
There was a problem hiding this comment.
Just to make sure I understand, if this migration runs twice things break; we would overwrite new_fund_account here with some empty info?
Member
Author
There was a problem hiding this comment.
Yes, but not sure if there is a way around this...
Contributor
There was a problem hiding this comment.
you can and should guard the migration by something, either StorageVersion, custom storage, or at the minimum spec_verion
emostov
approved these changes
Mar 23, 2022
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
Generally looks good - only potential issue I see is #5173 (comment)
kianenigma
reviewed
Mar 24, 2022
kianenigma
reviewed
Mar 24, 2022
kianenigma
reviewed
Mar 24, 2022
kianenigma
reviewed
Mar 24, 2022
kianenigma
approved these changes
Mar 24, 2022
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
minor issues, but LGTM.
Just makre sure to correct the other migration in Polkadot, if there is going to be a 9181 replacing 9180.
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Member
Author
|
bot merge |
paritytech-processbot
bot
deleted the
shawntabrizi-fix-crowdloan-migration
branch
louismerlin
added
D1-audited 👍
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the existing Crowdloan migration (#4772), where the deposits tracking in the Slots pallet was not migrated to the new accounts.