This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update dispute-coordinator documentation#4975
Merged
eskimor merged 1 commit intoparitytech:masterfrom Mar 1, 2022
Merged
Conversation
tdimitrov
added
B0-silent
eskimor
reviewed
Feb 23, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
Member
|
A bit more details - not code level, but general behavior would be good. |
tdimitrov
force-pushed
the
dispute-coordinator-docs
branch
2 times, most recently
from
bf42ac9 to
a57e816
Compare
tdimitrov
force-pushed
the
dispute-coordinator-docs
branch
2 times, most recently
from
da1b2cf to
7a105ba
Compare
eskimor
reviewed
Feb 28, 2022
Member
eskimor
left a comment
eskimor
left a comment
There was a problem hiding this comment.
Much better, just a few nits. Thanks @tdimitrov
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
ordian
reviewed
Feb 28, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
drahnr
reviewed
Feb 28, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
drahnr
reviewed
Feb 28, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
drahnr
reviewed
Feb 28, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
drahnr
reviewed
Feb 28, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
drahnr
reviewed
Feb 28, 2022
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
roadmap/implementers-guide/src/node/disputes/dispute-coordinator.md
Outdated
Show resolved
Hide resolved
tdimitrov
force-pushed
the
dispute-coordinator-docs
branch
from
3a7c59b to
1396083
Compare
Contributor
Author
|
@drahnr I've left a few of your comments unaddressed because they are copy-paste from the actual source code. I think it's better to leave it this way. Any objections? |
Contributor
|
I don't think we should make one or the other the source of truth, adjust both sides as needed to convey a coherent view with the underlying motivation. That said, it's fine for now, they were only nits after all :) |
tdimitrov
force-pushed
the
dispute-coordinator-docs
branch
from
1396083 to
be219c6
Compare
Contributor
Author
I've fixed the comments too. The change is too small to defer. |
eskimor
reviewed
Mar 1, 2022
Include changes made in paritytech#4134 and paritytech#4854 Fixes paritytech#4397
tdimitrov
force-pushed
the
dispute-coordinator-docs
branch
from
be219c6 to
17d6eb9
Compare
Contributor
Author
|
To wrap up the discussions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include changes made in #4134 and #4854
Fixes #4397