Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Changes for substrate#3821#490

Closed
expenses wants to merge 2 commits intoparitytech:masterfrom
expenses:debug-changes
Closed

Changes for substrate#3821#490
expenses wants to merge 2 commits intoparitytech:masterfrom
expenses:debug-changes

Conversation

@expenses
Copy link
Contributor

paritytech/substrate#3821 added a Debug derive to rstd, which we can use instead of #[cfg_attr(feature = "std", derive(Encode))]. It also broke some other stuff to do with Debug:

error[E0277]: `registrar::LimitParathreadCommits<T>` doesn't implement `core::fmt::Debug`
   --> /Users/ashley/projects/polkadot/runtime/src/registrar.rs:505:30
    |
505 | impl<T: Trait + Send + Sync> SignedExtension for LimitParathreadCommits<T> where
    |                              ^^^^^^^^^^^^^^^ `registrar::LimitParathreadCommits<T>` cannot be formatted using `{:?}`
    |
    = help: the trait `core::fmt::Debug` is not implemented for `registrar::LimitParathreadCommits<T>`
    = note: add `#[derive(Debug)]` or manually implement `core::fmt::Debug`

This should only get merged once polkadot-master gets updated and the branch changes from polkadot-master to master have been reverted.

@parity-cla-bot
Copy link

It looks like @expenses signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@andresilva
Copy link
Contributor

andresilva commented Oct 23, 2019

Sorry but I was already working on this and didn't notice this PR. The proper solution is to use a derive introduced in paritytech/substrate#3821 called RuntimeDebug. I opened a PR that updates to latest substrate-master branch (#491).

@gavofyork gavofyork closed this Oct 23, 2019
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
* Start

* More work

* Add proc-macro for `validate_block`

* Make everything compile

* Add some test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants