This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Changes for substrate#3821#490
Closed
expenses wants to merge 2 commits intoparitytech:masterfrom
expenses:debug-changes
Closed
Changes for substrate#3821#490expenses wants to merge 2 commits intoparitytech:masterfrom expenses:debug-changes
expenses wants to merge 2 commits intoparitytech:masterfrom
expenses:debug-changes
Conversation
|
It looks like @expenses signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Contributor
|
Sorry but I was already working on this and didn't notice this PR. The proper solution is to use a derive introduced in paritytech/substrate#3821 called |
imstar15
pushed a commit
to imstar15/polkadot
that referenced
this pull request
Aug 25, 2021
* Start * More work * Add proc-macro for `validate_block` * Make everything compile * Add some test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paritytech/substrate#3821 added a
Debugderive to rstd, which we can use instead of#[cfg_attr(feature = "std", derive(Encode))]. It also broke some other stuff to do withDebug:This should only get merged once
polkadot-mastergets updated and the branch changes frompolkadot-mastertomasterhave been reverted.