This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add MaxUnlockingChunks to staking configs; Companion to #10670 #4823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
added
A0-please_review
emostov
changed the title
kianenigma
approved these changes
Feb 1, 2022
|
Waiting for commit status. |
kianenigma
approved these changes
Mar 1, 2022
| sp-core = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false } | ||
| sp-keystore = { git = "https://github.com/paritytech/substrate", branch = "master", optional = true } | ||
| sp-tracing = { version = "4.0.0-dev", branch = "master", git = "https://github.com/paritytech/substrate", default-features = false, optional = true } | ||
| sp-tracing = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false, optional = true } |
Contributor
Author
There was a problem hiding this comment.
I needed to remove the version to get the companion to build
Contributor
Author
There was a problem hiding this comment.
But let me check with the parachains team to see if this is ok
Contributor
Author
There was a problem hiding this comment.
@bkchr made a PR with the same change https://github.com/paritytech/polkadot/pull/5017/files
paritytech-processbot
bot
deleted the
zeke-staking-max-unlocking-companion
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to paritytech/substrate#10670