This repository was archived by the owner on Nov 15, 2023. It is now read-only.
derive Copy and Clone for Upgrade signals (#4637) #4647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation is to resolve [this TODO](https://github.com/paritytech/cumulus/blob/b9ba74892ad6199128a45703b89ff06f429be7fa/test/relay-sproof-builder/src/lib.rs#L73) eventually
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
pepyakin
added
A2-insubstantial
Contributor
Author
|
auto-approving since #4637 has received two approves |
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
|
Bot will approve on the behalf of @pepyakin, since they are a team lead, in an attempt to reach the minimum approval count |
![paritytech-processbot[bot]](https://avatars.githubusercontent.com/in/144942?s=60&v=4){kind=small}
ordian
added a commit
that referenced
this pull request
Jan 3, 2022
* master: Set CurrentCodeHash before running some dispatchable benchmarks (#4645) paras: split tests (#4636) Bump quote from 1.0.10 to 1.0.14 (#4632) Bump pin-project from 1.0.8 to 1.0.9 (#4606) chore: fix copy&paste and tidy comments (#4646) derive Copy and Clone for Upgrade signals (#4637) (#4647) paras: fix upgrade restriction signal (#4603) configuration: Rename validation_upgrade_{frequency -> cooldown} (#4635) Bump lru from 0.7.1 to 0.7.2 (#4633) paras: add governance control dispatchables (#4575)
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is resubmission of #4637 which was accidentially merged into the previous PR in the stack rather than in master. I opted in for resubmission because otherwise those two PRs would be squashed as a single commit on master, which is not ideal.