This repository was archived by the owner on Nov 15, 2023. It is now read-only.
bridge: add all PeerIds of an AuthorityId to the gossip topology#4621
Closed
bridge: add all PeerIds of an AuthorityId to the gossip topology#4621
PeerIds of an AuthorityId to the gossip topology#4621Conversation
ordian
added
A0-please_review
ordian
commented
Dec 28, 2021
| NetworkService::add_known_address(&*self, peer_id.clone(), multiaddr); | ||
| found_peer_id = Some(peer_id); | ||
| } | ||
| found_peer_id |
Author
There was a problem hiding this comment.
hmm, looking at this code again, req/resp still assumes one peer_id per authorityid?
eskimor
approved these changes
Dec 28, 2021
Author
|
Now that @eskimor reminded me of paritytech/substrate#10259 (comment), I'm convinced we shouldn't do this and instead ensure one PeerId per AuthorityId via type-system maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4615