Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Comments

Do not log PVF prunning every hour#4372

Merged
bkchr merged 1 commit intomasterfrom
pep-annoying-pruning-log
Nov 26, 2021
Merged

Do not log PVF prunning every hour#4372
bkchr merged 1 commit intomasterfrom
pep-annoying-pruning-log

Conversation

@pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Nov 25, 2021

This lowers the level of the PVF pruning.

Closes #4361

@pepyakin
Copy link
Contributor Author

pepyakin commented Nov 25, 2021 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open.

This was referenced Nov 25, 2021
Merged
Closed
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 25, 2021
@pepyakin pepyakin changed the title Do not log PVF prunning every hour (testing graphite) Do not log PVF prunning every hour Nov 25, 2021
@pepyakin pepyakin force-pushed the pep-annoying-pruning-log branch from f220e26 to 707ca9c Compare November 25, 2021 16:25
@pepyakin pepyakin changed the base branch from pep-inclusion-remove-unused-var to pep-new-constraints November 25, 2021 16:25
@pepyakin pepyakin added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Nov 25, 2021
@pepyakin pepyakin changed the title (testing graphite) Do not log PVF prunning every hour Do not log PVF prunning every hour Nov 25, 2021
Base automatically changed from pep-new-constraints to master November 26, 2021 11:53
@pepyakin
Do not log PVF prunning every hour
e75b73d 
This lowers the level of the PVF pruning.

Closes #4361
@pepyakin pepyakin requested a review from slumber November 26, 2021 11:57
@pepyakin pepyakin mentioned this pull request Nov 26, 2021
Merged
@pepyakin pepyakin force-pushed the pep-annoying-pruning-log branch from 707ca9c to e75b73d Compare November 26, 2021 12:15
slumber
slumber approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@slumber slumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder was this message annoying? I've seen an issue about finished execution log being huge due to the head data, but what about this one?

@bkchr bkchr merged commit e83aeba into master Nov 26, 2021
@bkchr bkchr deleted the pep-annoying-pruning-log branch November 26, 2021 15:42
@pepyakin
Copy link
Contributor Author

pepyakin commented Nov 26, 2021

@slumber yep, I was explicitly told by @wpank that it's annoying.

The head data thing still stands, but here I was more testing graphite and head data is more involved, so picked this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bkchr bkchr bkchr approved these changes

@slumber slumber slumber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't print PVF pruning messages once in an hour

3 participants

@pepyakin @bkchr @slumber