Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Update release issue template #4268

Closed
s3krit wants to merge 1 commit into from
Closed

Update release issue template #4268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ candidate branch or started an additional release candidate branch (rc-2, rc-3,
notes](#release-notes)
- [ ] Check that [build artifacts](#build-artifacts) have been added to the
draft-release
- [ ] Once the new release has been published, bump `spec_version` in Polkadot, Westend and Kusama.
- [ ] Once the new releaes has been published, bump the version string in various `Cargo.toml` files
- For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i 's/^version = "0.9.12"/version = "0.9.13"/g'`
Copy link
Contributor

@chevdor chevdor Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command "as is" does not work on MacOS. I am testing a small variation.

Copy link
Contributor

@chevdor chevdor Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the following work for you as well ?

Suggested change
- For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i 's/^version = "0.9.12"/version = "0.9.13"/g'`
- For example, bumping v0.9.12 to v0.9.13: `grep -rl '^version = "0.9.12"' ./**/Cargo.toml | xargs sed -i '' -e 's/^version = "0.9.12"/version = "0.9.13"/g'`

Copy link
Contributor Author

@s3krit s3krit Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the suggestion went a bit wonky - are you suggesting to swap -i for -e?

Copy link
Contributor

@chevdor chevdor Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no no, as it shows: to explicitely tell -i to be empty and -e to the previous content.


## Notes

Expand Down