This repository was archived by the owner on Nov 15, 2023. It is now read-only.
req/resp: use IfDisconnected::ImmediateError#4253
Merged
paritytech-processbot[bot] merged 3 commits intomasterfrom Nov 12, 2021
Merged
req/resp: use IfDisconnected::ImmediateError#4253paritytech-processbot[bot] merged 3 commits intomasterfrom
paritytech-processbot[bot] merged 3 commits intomasterfrom
Conversation
ordian
added
A0-please_review
tomaka
approved these changes
Nov 10, 2021
eskimor
approved these changes
Nov 10, 2021
Author
|
bot merge |
paritytech-processbot
bot
deleted the
ao-req-resp-immediate-error-if-disconnected
branch
drahnr
pushed a commit
that referenced
this pull request
Nov 15, 2021
* req/resp: use IfDisconnected::ImmediateError * remove outdated comments * fmt
23 tasks
crystalin
pushed a commit
to moonbeam-foundation/polkadot
that referenced
this pull request
Mar 2, 2022
This reverts commit c18d42d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, we should attempt to preconnect to every validator and trying to connect if disconnected in req/resp will only waste time.
we are supposed to be preconnected to the next session authorities as well, so it shouldn't be racy at session boundaries