Weights for para inherent by emostov · Pull Request #4202 · paritytech/polkadot

emostov · 2021-11-01T16:59:50Z

target branch: bernhard-inherent-filtering
target pr: #4028

Bumps [trybuild](https://github.com/dtolnay/trybuild) from 1.0.45 to 1.0.48. - [Release notes](https://github.com/dtolnay/trybuild/releases) - [Commits](dtolnay/trybuild@1.0.45...1.0.48) --- updated-dependencies: - dependency-name: trybuild dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update for warp sync * update Substrate Co-authored-by: parity-processbot <>

…geVersion (#4035) * wip * Remove unused members

* Remove bridges from check_line_width * Remove bridges from spellcheck

* Substrate companion for #9966 * Bump spec_versions * Update Substrate

…4036) * validator-discovery: remove from peer set before inserting * bump spec versions * rework into a companion * fmt * fix * fix * one more time * one more try * one more try * Revert "one more try" This reverts commit ab6568d. * one more try * one more try * Revert "one more try" This reverts commit 8d7369f. * fix a warning * fix another warn * correct log * fix compilation * ffs * less cloning * Apply suggestions from code review Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * add comments and a small refactoring * use set_reserved_peers * cargo update -p sp-io * rename added to num_peers * update Substrate Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by: parity-processbot <>

Bumps [trybuild](https://github.com/dtolnay/trybuild) from 1.0.48 to 1.0.49. - [Release notes](https://github.com/dtolnay/trybuild/releases) - [Commits](dtolnay/trybuild@1.0.48...1.0.49) --- updated-dependencies: - dependency-name: trybuild dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add para pallets to polkadot benchmarks * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::configuration --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_configuration.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::initializer --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_initializer.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras.rs Co-authored-by: Parity Bot <admin@parity.io>

Bumps [strum](https://github.com/Peternator7/strum) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/Peternator7/strum/releases) - [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md) - [Commits](https://github.com/Peternator7/strum/commits) --- updated-dependencies: - dependency-name: strum dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.29 to 1.0.30. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.29...1.0.30) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* overseer: simplify debugging some more * chore: undo gitignore change

* Companion PR for ss58 crate * cargo fmt * Rename * into() * into() * updating substrate (ideally use bot merge)

Bumps [trybuild](https://github.com/dtolnay/trybuild) from 1.0.49 to 1.0.50. - [Release notes](https://github.com/dtolnay/trybuild/releases) - [Commits](dtolnay/trybuild@1.0.49...1.0.50) --- updated-dependencies: - dependency-name: trybuild dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Extend xcm-simulator with a fuzzer for xcm exec This commit adds a very basic fuzzer that fuzzes the xcm exectution, in particular the process_instruction function. * Update cargo.toml in xcm-simulator-fuzzer * Add xcm-fuzzer to honggfuzz workflow * Update Cargo.lock * Update xcm/xcm-simulator/fuzzer/Cargo.toml so honggfuzz shows up on top Co-authored-by: Keith Yeung <kungfukeith11@gmail.com> * Update relay_chain.rs in xcm-fuzzer * Use MAX_XCM_DECODE_DEPTH instead of hardcoded decode limit in xcm-fuzzer * Add comment on how to generate coverage report in xcm-fuzzer * fix warnings, fmt, and unused result * fix compiler Co-authored-by: Vincent Ulitzsch <vincent.ulitzsch@srlabs.de> Co-authored-by: Vincent Ulitzsch <vincent@srlabs.de> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

* Dispatchable XCMs should translate to v0 * Formatting * Update Westend's XCM WrapVersion

* found issue * fix up * remove printlns

* Update wasmtime config to match new version * update Substrate Co-authored-by: parity-processbot <>

…4067) * Move runtime to with_transaction in order to Rollback state changes * add assert_storage_noop to tests

Bumps [proc-macro2](https://github.com/alexcrichton/proc-macro2) from 1.0.29 to 1.0.30. - [Release notes](https://github.com/alexcrichton/proc-macro2/releases) - [Commits](dtolnay/proc-macro2@1.0.29...1.0.30) --- updated-dependencies: - dependency-name: proc-macro2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create a README for XCMv1 detailing notable changes * Update xcm/src/v1/README.md Co-authored-by: Gavin Wood <gavin@parity.io> * Update xcm/src/v1/README.md Co-authored-by: David <dvdplm@gmail.com> * Update xcm/src/v1/README.md Co-authored-by: David <dvdplm@gmail.com> * Update xcm/src/v1/README.md Co-authored-by: David <dvdplm@gmail.com> * Update xcm/src/v1/README.md Co-authored-by: David <dvdplm@gmail.com> * Link to relevant PR for a full list of changes * Typo * Add notable changes to top-level XCM rustdoc * Appease spellchecker Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: David <dvdplm@gmail.com>

* Remove the upload of the non compressed runtimes * Fix template * Add loggin for local testing * Keep simple logger but remove the need for another dependency

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>

* companion for substrate/10013 * remove in buffer * update Substrate Co-authored-by: parity-processbot <>

runtime/parachains/src/paras_inherent.rs

drahnr · 2021-11-05T11:33:41Z

runtime/parachains/src/builder.rs

 				DisputeStatementSet {
 					candidate_hash: candidate_hash.clone(),
-					session: self.target_session,
+					session: session,


Should be just session, right?

runtime/parachains/src/paras_inherent.rs

…aritytech/polkadot into zeke-create-enter-benchmarks-5

emostov · 2021-11-05T17:42:02Z

runtime/parachains/src/paras_inherent.rs

+
+		#[test]
+		// Ensure that when a block is overlength due to disputes and bitfields, we abort
+		fn limit_candidates_overlength_failure() {


This test is really similiar to limit_dispute_data_ignore_backed_candidates_failure - Is there a way to show that the reason it failed is different?

emostov · 2021-11-05T17:53:35Z

runtime/parachains/src/paras_inherent.rs

+						frame_system::RawOrigin::None.into(),
+						expected_para_inherent_data,
+					),
+					DispatchError::from(Error::<Test>::InherentOverweight),


Is there a way we can show this is overweight due to quantity of bitfields and not just because of the added disputes?

It would be good to show how this is different than limit_dispute_data_ignore_backed_candidates_failure

Use `StorageKey` in the rpc call `getStorage` instead of `[u8;32]`

…enchmarks-5

emostov · 2021-11-08T16:44:20Z

relevant changes have been brought into #4028

dependabot bot and others added 30 commits November 1, 2021 12:27

Update for warp sync (#3564)

2b93f6d

* Update for warp sync * update Substrate Co-authored-by: parity-processbot <>

Polkadot: Remove configuration's runtime migration and just set Stora…

fd100c8

…geVersion (#4035) * wip * Remove unused members

Remove bridges from checks (#4040)

9ce195f

* Remove bridges from check_line_width * Remove bridges from spellcheck

Bump spec_versions (#4041)

571d5b6

Substrate companion for #9966 (#4037)

04cd5ba

* Substrate companion for #9966 * Bump spec_versions * Update Substrate

Fixes broken docker link in docker descriptiob (#4043)

dccf066

Benchmarking for paras inherent WIP

3e2aab4

Add paras_inherent WeightInfo to runtimes

ea00b14

overseer: simplify debugging some more (#4053)

1a22fee

* overseer: simplify debugging some more * chore: undo gitignore change

Companion PR for ss58 crate (#3953)

05e5336

* Companion PR for ss58 crate * cargo fmt * Rename * into() * into() * updating substrate (ideally use bot merge)

Dispatchable XCMs should translate to v0 (#4062)

30e1218

* Dispatchable XCMs should translate to v0 * Formatting * Update Westend's XCM WrapVersion

Fix XCM Weights on Westend (#4066)

2f70323

* found issue * fix up * remove printlns

Update wasmtime config to match new version in substrate (#4063)

82c1f15

* Update wasmtime config to match new version * update Substrate Co-authored-by: parity-processbot <>

Move runtime to with_transaction in order to Rollback state changes (#…

1de0b2b

…4067) * Move runtime to with_transaction in order to Rollback state changes * add assert_storage_noop to tests

Switch to compressed runtimes (#4061)

17508ef

* Remove the upload of the non compressed runtimes * Fix template * Add loggin for local testing * Keep simple logger but remove the need for another dependency

use WEIGHT_PER_SECOND (#4077)

019a9bf

fix restart issue of staking miner (#4073)

569c1e6

Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>

companion for substrate/10013 (#4078)

c4c24de

* companion for substrate/10013 * remove in buffer * update Substrate Co-authored-by: parity-processbot <>

use pipeline-scripts for dependent projects script (#4017)

9b0dcb4

Modify Pair generation implementation to make use of u8 slice

aa39dcf

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Show resolved Hide resolved

Lldenaurois added 2 commits November 5, 2021 11:51

Address Feedback and nightly fmt

1440f7a

Refine test scenarios and add comments

58fc112

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

drahnr reviewed Nov 5, 2021

View reviewed changes

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

drahnr reviewed Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov commented Nov 5, 2021

View reviewed changes

runtime/parachains/src/paras_inherent.rs Outdated Show resolved Hide resolved

emostov and others added 5 commits November 5, 2021 17:07

WIP fix benchmark builder usage

b276d31

Add tests to cover edge cases

1b10360

Finish fixing benchmark builder usage; Run fmt

af82fe5

Add remote_disputes logic

e7d60ce

Merge branch 'zeke-create-enter-benchmarks-5' of https://github.com/p…

3409b4f

…aritytech/polkadot into zeke-create-enter-benchmarks-5

emostov commented Nov 5, 2021

View reviewed changes

Update tests to use new over weight error; Update comments

bb69aff

emostov commented Nov 5, 2021

View reviewed changes

emostov and others added 5 commits November 5, 2021 18:57

Just some small comment touch ups

4573e88

fix(staking miner): use StorageKey in getStorage (#4231)

d985794

Use `StorageKey` in the rpc call `getStorage` instead of `[u8;32]`

Add random selection of overlength remote disputes

2fb0c11

fix(staking miner): use StorageKey in getStorage (#4231)

cdfff7c

Use `StorageKey` in the rpc call `getStorage` instead of `[u8;32]`

Merge remote-tracking branch 'parity/master' into zeke-create-enter-b…

b08da55

…enchmarks-5

emostov closed this Nov 8, 2021

louismerlin removed the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Oct 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weights for para inherent#4202

Weights for para inherent#4202
emostov wants to merge 137 commits intobernhard-inherent-filteringfrom
zeke-create-enter-benchmarks-5

emostov commented Nov 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drahnr Nov 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emostov Nov 5, 2021

Uh oh!

emostov Nov 5, 2021

Uh oh!

emostov Nov 5, 2021

Uh oh!

emostov commented Nov 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

emostov commented Nov 1, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drahnr Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emostov Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

emostov Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

emostov Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

emostov commented Nov 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants