This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Weights for enacting candidates in paras inherent#4172
Open
Weights for enacting candidates in paras inherent#4172
Conversation
emostov
commented
Oct 28, 2021
emostov
commented
Oct 28, 2021
emostov
commented
Oct 29, 2021
runtime/parachains/src/hrmp.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
// - in loop
// - get 1r,
// - insert 1w
// - append 1w
// - get 1r
// - insert 1r
emostov
commented
Oct 29, 2021
runtime/parachains/src/paras.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
// - mutate 1r,1w
// - insert 1r
// - mutate 1r, 1w
// - write 1w
// - mutate, insert 1r,2w
// - insert 1w
emostov
commented
Oct 29, 2021
| } | ||
|
|
||
| pub(crate) fn prune_dmq_weight() -> Weight { | ||
| T::DbWeight::get().reads_writes(1, 1) |
emostov
commented
Oct 29, 2021
runtime/parachains/src/paras.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
// - insert 1w
// - remove 1r
// - remove 1r
// - take 1r,1w
// - get 1r
// - insert 1w
// - deposit_log (append) 1w
// - note_past_code
// - mutate 1r,1w
// - insert 1w
// - mutate 1r, 1w
emostov
commented
Oct 29, 2021
runtime/parachains/src/hrmp.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
// - mutate 1r,1w
// - max_pruneable_channels * {insert || remove, mutate, get} r2, w2
// - insert w1
emostov
commented
Oct 29, 2021
| } else { | ||
| 0 | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
// - mutate
// - mutate
// - mutate
…ytech/polkadot into zeke-track-enact-candidate
emostov
commented
Oct 29, 2021
emostov
commented
Oct 29, 2021
emostov
commented
Oct 29, 2021
emostov
commented
Oct 29, 2021
runtime/parachains/src/paras.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
// - mutate 1r, 1w
// - mutate 1r, 1w
// - insert 1w
// - mutate 1r, 1w
// - deposit_log (append) 1w
// - increase_code_ref 1r, 2w
// - insert 1w
Contributor
Author
There was a problem hiding this comment.
^ these are notes about how I counted reads and writes
emostov
commented
Oct 29, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
reviewed
Dec 3, 2021
drahnr
approved these changes
Dec 6, 2021
drahnr
suggested changes
Dec 6, 2021
Contributor
drahnr
left a comment
There was a problem hiding this comment.
Previous review was moot, only saw part of the diff.
drahnr
reviewed
Dec 10, 2021
drahnr
approved these changes
Dec 10, 2021
This was referenced Dec 11, 2021
Open
emostov
commented
Dec 11, 2021
Contributor
Author
|
@drahnr Can this be closed? |
Contributor
|
I think it's still desirable to account for the enacted candidates, but it depends how much work that'd entail to update vs reimpl? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
enact_candidatecall and adds it to the returned weight of paras inherententer. Previously we where not tracking the weight from enacting candidates.enact_candidate_weight, which gives us the worst case weight which we can then use prior to calling enter.cc @pepyakin
Notes for reviewers:
relates to #4044
skip check-dependent-cumulus