Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Runtime API for retrieving included state of a candidate#4054

Closed
eskimor wants to merge 11 commits intomasterfrom
rk-scrape-included
Closed

Runtime API for retrieving included state of a candidate#4054
eskimor wants to merge 11 commits intomasterfrom
rk-scrape-included

Conversation

@eskimor
Copy link
Member

@eskimor eskimor commented Oct 11, 2021

This will be used for disputes in order to prioritize candidates that have been seen included on some chain.

@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Oct 11, 2021
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs impl guide changes

@rphmeier
Copy link
Contributor

Also, runtime API versioning as discussed in #4033 ?

@eskimor
Copy link
Member Author

eskimor commented Oct 12, 2021

Also, runtime API versioning as discussed in #4033 ?

Yep. I was planning on adding this in a separate PR. But let's see, I might add it right here as well. Just wanted to get the actual runtime changes out.

@eskimor eskimor changed the title Runtime API for retriving included state of a candidate Runtime API for retrieving included state of a candidate Oct 12, 2021
@eskimor
Copy link
Member Author

eskimor commented Oct 12, 2021

Closing for now, will revive once we have disputes enabled in the runtime.

@eskimor eskimor closed this Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants