Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Comments

comment out bridges runtime modules (broken) and update Rococo chain-spec#3780

Merged
rphmeier merged 4 commits intomasterfrom
rh-remove-bridges-rococo
Sep 3, 2021
Merged

comment out bridges runtime modules (broken) and update Rococo chain-spec#3780
rphmeier merged 4 commits intomasterfrom
rh-remove-bridges-rococo

Conversation

@rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Sep 3, 2021 •
edited
Loading

  1. Remove all bridge-related pallets from Rococo (there was an unconditional panic in there somewhere)
  2. Create new rococo.json

@rphmeier rphmeier added the A0-please_review Pull request needs code review. label Sep 3, 2021
@rphmeier rphmeier changed the title comment out bridges runtime modules (broken) comment out bridges runtime modules (broken) and update Rococo chain-spec Sep 3, 2021
@rphmeier rphmeier added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Sep 3, 2021
@rphmeier
Copy link
Contributor Author

rphmeier commented Sep 3, 2021

I've verified that a rococo-local testnet works. Will roll out to Rococo as soon as green

@rphmeier
Copy link
Contributor Author

rphmeier commented Sep 3, 2021

cc @tomusdrw @svyatonik Please prepare a PR to re-enable all bridges code, but with the appropriate migrations so the runtime doesn't panic.

Lldenaurois
Lldenaurois approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@Lldenaurois Lldenaurois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned the top and bottom of each addition removal and am quite confident that everything that was commented out faithfully.

Tests green indicate that the feature was removed from the runtime successfully.

LGTM

@rphmeier rphmeier merged commit 6d1d883 into master Sep 3, 2021
@rphmeier rphmeier deleted the rh-remove-bridges-rococo branch September 3, 2021 21:46
ordian added a commit that referenced this pull request Sep 6, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
720c91a 
* master:
  Add tests and modify as_vec implementation (#3715)
  Bump structopt from 0.3.22 to 0.3.23 (#3770)
  bump substrate and beefy (#3789)
  set `DisputesHandler` in initializer (#3788)
  Bump futures from 0.3.16 to 0.3.17 (#3742)
  Convert rococo chainspec to raw chainspec (#3785)
  feat/overseer: introduce closure init (#3775)
  comment out bridges runtime modules (broken) and update Rococo chain-spec (#3780)
  Add VoteLocking config (#3734)
  Enable disputes on rococo (#3764)
  XCM: Automatic Version Negotiation (#3736)
@tomusdrw tomusdrw mentioned this pull request Nov 15, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Lldenaurois Lldenaurois Lldenaurois approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rphmeier @Lldenaurois