Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adjust priority from CheckWeight extension #3743

Closed
wants to merge 2 commits into from
Closed

Conversation

tomusdrw
Copy link
Contributor

Kind of a companion of paritytech/substrate#9596 (strict companion not necessary, cause there are no breaking changes).

@tomusdrw tomusdrw added A0-please_review Pull request needs code review. B7-runtimenoteworthy D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 30, 2021
@tomusdrw tomusdrw added the C3-medium PR touches the given topic and has a medium impact on builders. label Sep 1, 2021
@kianenigma
Copy link
Contributor

This is approve from my PoV, but I am a bit hesitant to accept that it is only nice to have audit. thoughts @shawntabrizi?

@tomusdrw tomusdrw added D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Sep 8, 2021
@shawntabrizi
Copy link
Member

To be in the [0-10] range, shouldn't the adjustment be 1/10 of the max block weight?

@jakoblell jakoblell added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. labels Sep 20, 2021
@tomusdrw tomusdrw closed this Sep 22, 2021
@tomusdrw
Copy link
Contributor Author

Closing in favour of paritytech/substrate#9834

@tomusdrw tomusdrw deleted the td-9596-companion branch September 22, 2021 09:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C3-medium PR touches the given topic and has a medium impact on builders. D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants