This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduce new Runtime API endpoint for fetching the validation data#3728
Merged
paritytech-processbot[bot] merged 9 commits intomasterfrom Oct 22, 2021
Merged
Introduce new Runtime API endpoint for fetching the validation data#3728paritytech-processbot[bot] merged 9 commits intomasterfrom
paritytech-processbot[bot] merged 9 commits intomasterfrom
Conversation
`persisted_validation_data_with_code_hash` that will be used by the candidate validation subsystem in order to decrease amount of runtime API requests.
1 task
pepyakin
reviewed
Aug 27, 2021
Contributor
pepyakin
left a comment
pepyakin
left a comment
There was a problem hiding this comment.
One of the things we would still need to do is to update the implementer's guide.
Contributor
Author
Yea, it will also be necessary to update the subsystem diagram, but first I want to finalize the PR, e.g. there're naming issues, as you mentioned. |
slumber
added
A0-please_review
Member
|
We should probably also bump the version of the runtime api? And add some fallback for when it is not available? |
Contributor
|
The code that depends on this PR, #3655, is actually a low-priority one. We can as well delay the dependent PR until after this gets on the relay-chain. This way we will save us some effort by not introducing a fallback. Do you think it is sensible? |
Member
|
Okay, sounds fine. |
pepyakin
approved these changes
Oct 13, 2021
slumber
force-pushed
the
slumber-runtime-api-upgrade
branch
from
eea80d2 to
813b8cc
Compare
Contributor
|
bot merge |
ordian
added a commit
that referenced
this pull request
Oct 27, 2021
* master: (73 commits) Fix XCM Teleport Benchmark (#4146) Allow Queries and Subscriptions (#4150) Fix weights on hard-coded XCM fragments (#4144) Bump spec versions (#4142) Bump libc from 0.2.104 to 0.2.105 (#4141) Enable bags-list pallet in polkadot (#4080) Move artifacts states into memory in PVF validation host (#3907) Introduce new Runtime API endpoint for fetching the validation data (#3728) export xcm_pallet config (#4116) Apply cargo fmt (#4122) remove logging from the check-dependent-* job (#4120) Remove stale migrations (#4107) Bump structopt from 0.3.23 to 0.3.25 (#4098) remove hardcoded pipeline scripts tag (#4109) Bump libc from 0.2.103 to 0.2.104 (#4099) some spelling fixes (#4088) polkadot: remove call filters on registrar pallets (#4093) Fix typos in docs (#4092) Rename Statemint where appropriate (#4087) bump substrate (#4091) ...
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
…3728) * Introduce new Runtime API endpoint `persisted_validation_data_with_code_hash` that will be used by the candidate validation subsystem in order to decrease amount of runtime API requests. * Node-side part of new runtime API request * Define code hash getter via macro * Rename new endpoint to `assumed_validation_data` * Docs for runtime API impl of new endpoint * AssumedValidationData specialized request function * fmt
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corresponding implementers guide section will be updated along with the candidate validation subsystem as a part of #3655
Resolves #3700
cumulus companion: paritytech/cumulus#693