Conversation
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
This reverts commit 39181b4.
Co-authored-by: Gavin Wood <gavin@parity.io>
shawntabrizi
added
A0-please_review
| pub type LocalOriginToLocation = xcm_builder::SignedToAccountId32<Origin, AccountId, AnyNetwork>; | ||
|
|
||
| impl pallet_xcm::Config for Runtime { | ||
| // The config types here are entirely configurable, since the only one that is sorely needed |
There was a problem hiding this comment.
| // The config types here are entirely configurable, since the only one that is sorely needed | |
| // The config types here are entirely configurable, since the only one that is surely needed |
?
| } | ||
| } | ||
|
|
||
| pub type Barrier = AllowUnpaidExecutionFrom<All<MultiLocation>>; |
There was a problem hiding this comment.
This is better than struct YesItShould that I put for benchmarking mock, perhaps use this there as well: https://github.com/paritytech/polkadot/pull/3563/files#diff-4956fec0e6b5a0cf3ad1a1980b05285ac79c5a91d5edb15863d19b1519e8ae40R21
|
|
||
| block_builder.push_polkadot_extrinsic(execute).expect("pushes extrinsic"); | ||
|
|
||
| let block = block_builder.build().expect("Finalizes the block").block; |
There was a problem hiding this comment.
| let block = block_builder.build().expect("Finalizes the block").block; | |
| let block = block_builder.build().expect("finalizes the block").block; |
| futures::executor::block_on(client.import(sp_consensus::BlockOrigin::Own, block)) | ||
| .expect("imports the block"); | ||
|
|
||
| client |
There was a problem hiding this comment.
why so complicated? why not just use the runtime primitives to test this?
There was a problem hiding this comment.
You can test the decode limit (which is checked at client-runtime boundary) with manual encode/decode. Also the execution limit can be checked here as well via the xcm-executor.
I recall that it had something to do with a strange rustc issue. Now's is a good time to rethink why we're doing it this way.
There was a problem hiding this comment.
We had to run the test in WASM in order to simulate a real-ish environment. Local testing with a native client would blow the stack with a depth of just 6, while on WASM, it began to OOM at around 84.
|
bot merge |
|
Trying merge. |
ghost
merged commit 
5 participants
Taking: #3555
And making it work for XCM v1