This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
shawntabrizi
added
B0-silent
apopiak
approved these changes
Aug 1, 2021
Contributor
apopiak
left a comment
apopiak
left a comment
There was a problem hiding this comment.
Awesome contribution to allow for integration testing 👍
Comment on lines
+64
to
+65
| #[macro_export] | ||
| macro_rules! decl_test_relay_chain { |
Contributor
There was a problem hiding this comment.
It would be great if you could add some doc comments for these macros.
Member
There was a problem hiding this comment.
lets follow up on that :)
shawntabrizi
approved these changes
Aug 1, 2021
Member
|
bot merge |
|
Trying merge. |
ghost
merged commit 
|
such a beautiful piece of code |
This was referenced Aug 3, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to the original xcm-simulator, all cumulus dependencies are removed. The new impl uses
XcmpMessageHandlerandDmpMessageHandlerabstractions, instead of directly calling cumulus pallets to handle xcmp and dmp. Users need to pass these implementations when declaring test parachain.In order to make the new impl work, the following definitions are moved to polkadot from cumulus(will need a cumulus companion PR):
XcmpMessageHandlertraitDmpMessageHandlertraitXcmpMessageFormatenum