This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
rphmeier
added
A0-please_review
6 tasks
rphmeier
force-pushed
the
rh-chain-selection-db-and-stagnant
branch
from
5b29541 to
7909fbd
Compare
ordian
approved these changes
Jun 21, 2021
* master: (33 commits) Update all weights, add run_all_benches.sh script (#3400) Enable over-bridge-messaging in Rococo/Wococo runtime (#3377) paras.rs to FRAME V2 (#3403) Add XCM Tracing (#3353) Use MaxEncodedLen trait from new parity-scale-codec v2.2 (#3412) bump a bunch of deps in parity-common (#3402) Warn on low connectivity. (#3408) origin to frame v2 (#3405) Enable logging in the puppet worker (#3411) make it easier to dbg stalls (#3351) XCM `canonicalize` + `prepend_with` fix (#3269) cleanup stream polls (#3397) Staking Miner (#3141) Companion for Substrate#8953 (#3140) Bump version, specs & substrate in prep for v0.9.8 (#3387) Fix busy loops. (#3392) Minor refactor (#3386) add simnet tests (#3381) BEEFY: adjust gossip (#3372) Companion for #9193 (#3376) ...
ordian
reviewed
Jul 6, 2021
| fn load_stagnant_at_up_to(&self, up_to: crate::Timestamp) | ||
| -> Result<Vec<(crate::Timestamp, Vec<Hash>)>, Error> | ||
| { | ||
| let stagnant_at_iter = self.inner.iter_with_prefix( |
There was a problem hiding this comment.
just a note, that this adds another reliance on iter_with_prefix which needs to be removed if we're to migrate off kvdb interface
Contributor
Author
There was a problem hiding this comment.
Right. I think that's fine for now based on discussions in Element
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the follow-ups to #3277 and closes #3293 .
I don't yet plug it into overseer as that'll take a DB migration, for which we should do the migration of dispute coordinator at the same time. I'd like to wait until #2581 is implemented before that, just in case there are further changes we want to make to the coordinator.
So this PR:
DbBackendfulfilling theBackendtrait.ChainSelectionMessage::Approvedand is ready for review when these checkboxes are all done.