This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
rphmeier
added
A3-in_progress
rphmeier
force-pushed
the
rh-forkchoice-guide
branch
from
75ff478 to
793d1f4
Compare
github-actions
bot
removed
the
A3-in_progress
rphmeier
changed the title
6 tasks
Lldenaurois
reviewed
Jun 17, 2021
| } | ||
| ``` | ||
|
|
||
| ## Candidate Selection Message |
Contributor
There was a problem hiding this comment.
I should have caught this. Making a note that when modifying subsystems, it's important to grep for all mentions of that subsystem in the implementer's guide.
Contributor
Author
There was a problem hiding this comment.
I noticed it when running mdbook serve locally; there were outdated references that printed warnings
Lldenaurois
approved these changes
Jun 17, 2021
Co-authored-by: Lldenaurois <ljdenaurois@gmail.com>
Co-authored-by: Lldenaurois <ljdenaurois@gmail.com>
Co-authored-by: Lldenaurois <ljdenaurois@gmail.com>
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Jun 17, 2021
* master: Companion #9019 (max rpc payload override) (#3276) Implementers' Guide: Chain Selection (#3262) CLI: Add missing feature checking and check if someone passes a file (#3283) Export 'TakeRevenue' trait. (#3278) Add XCM Decode Limit (#3273) Allow Council to Use Scheduler (#3237) fix xcm pallet origin (#3272) extract determine_new_blocks into a separate utility (#3261) Approval checking unit tests (#3252) bridges: update finality-grandpa to 0.14.1 (#3266) malus - mockable overseer mvp (#3224) use safe math (#3249) Companion for #8920 (Control Staking) (#3260) Companion for #8949 (#3216)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussions and experience of the implementers' guide in the past, I avoided specifying the subsystem in too much low-level detail. Although those types of descriptions are helpful for handing off code to be implemented, they lead to often-tedious and overlooked guide updates when making minor edits to the code after the initial implementation is done. The higher-level description taken here should allow for a lot of flexibility and further changes of implementation without those types of edits being made.