Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@bkchr
Copy link
Member

@bkchr bkchr commented Jul 4, 2019

No description provided.

@bkchr bkchr added the A0-please_review Pull request needs code review. label Jul 4, 2019
@bkchr bkchr requested a review from rphmeier July 4, 2019 16:32
@bkchr bkchr merged commit a5b223a into master Jul 5, 2019
@bkchr bkchr deleted the bkchr-exit-communication branch July 5, 2019 09:43
gavofyork pushed a commit that referenced this pull request Jul 5, 2019
* Make `communication_for` exit when we end a round

* Fix compilation
gavofyork added a commit that referenced this pull request Sep 17, 2019
* Initial crowdfund stuff

* Make `communication_for` exit when we end a round (#313)

* Make `communication_for` exit when we end a round

* Fix compilation

* Add file

* Rest of logic.

* Consts to Getters

* Cleanups

* Trying to get things to compile

* More patchwork

* Patch dissolve

* Patch `fix_deploy_data`, add getters to `NewBidder`

* Dispatchable functions compile... with warnings

* Fix some warnings and typos

* Whitespace to Tabs

* Update to use `into_sub_account`

* Add events

* Basic fixes to runtime logic and checking

* Check that auction in progress when creating

* Automatically assign end for crowdfund

* Update runtime/src/crowdfund.rs

Co-Authored-By: Amar Singh <[email protected]>

* Update runtime/src/crowdfund.rs

Co-Authored-By: Amar Singh <[email protected]>

* Update runtime/src/crowdfund.rs

Co-Authored-By: Amar Singh <[email protected]>

* Update crowdfund.rs

* Patch `NewRaise` logic

* Test compiles

* Make `NewRaised` logic even better

* Fix trie id generation, start to add some tests

* More tests

* Add more tests

* Finish tests

* Formatting nits

* Use `into_iter`

* Fix for latest Substrate updates

* Cleanup

* Fixes.

* Copyright header.

* Remove dead code.

* Reinstate actually alive code.

* Fix tests

Still have to write some new follow up tests though

* Make funds work before auction

* Test a fund which spans 2 auctions.

* Docs.

* Update doc
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
This changes the collator to print an error if the block that we can not
find is the genesis block, instead of only logging this as a `debug`
message. This should help people when they have registered the wrong
genesis state on the relay chain.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants