This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
shawntabrizi
added
B7-runtimenoteworthy
C1-low
Contributor
|
Let's leave this open and see if it is needed for any immediate release, thanks! |
kianenigma
approved these changes
May 24, 2021
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
The session pallet will use the old set, so this does what we intend it to do: https://github.com/paritytech/substrate/blob/4973e7e933dfdefcfc32b88eeb83309787fa9f5f/frame/session/src/lib.rs#L607
shawntabrizi
added
C7-high ❗️
and removed
C1-low
Closed
jakoblell
added
D1-audited 👍
coriolinus
approved these changes
May 27, 2021
Contributor
|
blocked on paritytech/substrate#8912 |
kianenigma
added
A1-onice
and removed
A0-please_review
Merged
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit
Contributor
|
goodbye onchain election. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @kianenigma
This will prevent a fallback to an on chain election solution, which can cause issues with block production when too complex.
This will mean the old set will continue to be used when the election fails.