Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Register ReadRuntimeVersionExt#3045

Merged
pepyakin merged 3 commits intomasterfrom
ser-runtime-version
May 19, 2021
Merged

Register ReadRuntimeVersionExt#3045
pepyakin merged 3 commits intomasterfrom
ser-runtime-version

Conversation

@pepyakin
Copy link
Copy Markdown
Contributor

@pepyakin pepyakin commented May 17, 2021 •
edited
Loading

This change makes runtime_version host function work again in PVFs by providing an implementation that looks for the version section in the binary. The legacy mechanism that involved calling into the given instance is not supported.

Related paritytech/substrate#8688

@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C7-high ❗️ D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 17, 2021
@pepyakin pepyakin requested a review from bkchr May 17, 2021 18:18
@pepyakin pepyakin mentioned this pull request May 17, 2021
Merged
@pepyakin pepyakin added B1-releasenotes and removed B0-silent Changes should not be mentioned in any release notes labels May 17, 2021
@pepyakin pepyakin marked this pull request as draft May 18, 2021 09:52
@pepyakin
Copy link
Copy Markdown
Contributor Author

pepyakin commented May 18, 2021

Let's wait for paritytech/substrate#8845 first.

@pepyakin
Update Substrate
bcc7d04 
This includes the fix of compilation for macOS platforms.
@pepyakin pepyakin marked this pull request as ready for review May 18, 2021 12:15
@pepyakin pepyakin added this to the release v0.9.2 milestone May 18, 2021
@bkchr
Copy link
Copy Markdown
Member

bkchr commented May 19, 2021

You need to merge master!

@pepyakin pepyakin merged commit 0eed4b0 into master May 19, 2021
@pepyakin pepyakin deleted the ser-runtime-version branch May 19, 2021 10:33
ordian added a commit that referenced this pull request May 19, 2021
@ordian
Merge branch 'master' into ao-alternative-validator-discovery-design
9d69bf8 
* master:
  Actually connect to new validators at session boundary. (#3055)
  Register ReadRuntimeVersionExt (#3045)
  Bump version & spec version in prep for v0.9.2 (#3046)
  Remove host configuration set migration from Kusama & Westend (#3050)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

release v0.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@pepyakin @bkchr