Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add parachain_desired_peer_count metric#3035

Merged
ordian merged 2 commits intoparitytech:masterfrom
tomaka:metric-reserved
May 21, 2021
Merged

Add parachain_desired_peer_count metric#3035
ordian merged 2 commits intoparitytech:masterfrom
tomaka:metric-reserved

Conversation

@tomaka
Copy link
Copy Markdown
Contributor

@tomaka tomaka commented May 17, 2021

Adds a metrics for the number of elements marked as reserved in a peer set, in order to know how many substreams are expected. At the moment, we only have metrics for the actual number of substreams.

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 17, 2021
eskimor
eskimor reviewed May 17, 2021
View reviewed changes
Comment thread node/network/bridge/src/lib.rs
@ordian ordian mentioned this pull request May 18, 2021
Merged
ordian
ordian approved these changes May 20, 2021
View reviewed changes
Copy link
Copy Markdown

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct now after #3052.

@ordian ordian added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label May 20, 2021
@ordian

This comment has been minimized.

Sign in to view
@tomaka
Copy link
Copy Markdown
Contributor Author

tomaka commented May 20, 2021

Sorry, I didn't merge master since the other day.

@tomaka
Copy link
Copy Markdown
Contributor Author

tomaka commented May 20, 2021

This metric wasn't the best before, but now that #3052 is merged, it makes more sense, right?

@ordian ordian removed the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label May 20, 2021
@ordian ordian merged commit bd83612 into paritytech:master May 21, 2021
@tomaka tomaka deleted the metric-reserved branch May 21, 2021 14:55
ordian added a commit that referenced this pull request May 21, 2021
@ordian
Merge branch 'master' into ao-downgrade-uberverbose-logs
ec814c5 
* master:
  State can be finished due to `Share` message. (#3070)
  Add `parachain_desired_peer_count` metric (#3035)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@eskimor eskimor eskimor left review comments

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaka @ordian @eskimor