Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Enable Pallet XCM for Kusama & Westend#2970

Merged
3 commits merged intomasterfrom
gav-xcm-for-westend-kusama
May 4, 2021
Merged

Enable Pallet XCM for Kusama & Westend#2970
3 commits merged intomasterfrom
gav-xcm-for-westend-kusama

Conversation

@gavofyork
Copy link
Member

@gavofyork gavofyork commented May 3, 2021

not-live because it doesn't touch Polkadot runtime.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 3, 2021
@gavofyork gavofyork added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels May 3, 2021
@shawntabrizi shawntabrizi self-requested a review May 3, 2021 17:30
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1 / N council here is given full access to XCM

@gavofyork
Copy link
Member Author

gavofyork commented May 3, 2021

yeah. that's fine. main point is to prevent arbitrary different accounts each with nothing-st-stake from sending arbitrary XCM.

Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to make sure that statemint or any downstream parachain correctly checks the threshold of the plurality origin

cc @joepetrowski

@apopiak
Copy link
Contributor

apopiak commented May 4, 2021

Note to make sure that statemint or any downstream parachain correctly checks the threshold of the plurality origin

cc @joepetrowski

It will check is_majority for now, could check other percentages later.

@andresilva
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented May 4, 2021

Trying merge.

@ghost ghost merged commit a27a83e into master May 4, 2021
@ghost ghost deleted the gav-xcm-for-westend-kusama branch May 4, 2021 16:49
andresilva added a commit that referenced this pull request May 4, 2021
* Enable Pallet XCM for Kusama & Westend

* Fixes

Co-authored-by: André Silva <andrerfosilva@gmail.com>
ordian added a commit that referenced this pull request May 6, 2021
* master:
  Squashed 'bridges/' changes from 89a76998..b2099c5c
  Enable Pallet XCM for Kusama & Westend (#2970)
  kusama, westend: use proper parachain session keys (#2975)
  change statemint id (not system para) (#2974)
  runtime: remove random_seed from BlockBuilder API (#2968)
  runtime: remove beefy and mmr from westend (again) (#2972)
  Do peer connect later (as it happens in reality). (#2971)
  More secure `Signed` implementation (#2963)
  runtime: remove BabePalletPrefix impls for old migration (#2967)
  Companion for Substrate#8526 (#2845)
  Companion for Multi-phase elections solution resubmission (#2648)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants