This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Track the collation status in the collator protocol#2465
Merged
3 commits merged intomasterfrom Feb 17, 2021
Merged
Conversation
This pr changes the collator protocol to track the status of a collation. This is mainly used to log the status of a collation when it is removed to inform the user if a collation maybe never reached a validator.
bkchr
added
A0-please_review
rphmeier
reviewed
Feb 17, 2021
rphmeier
approved these changes
Feb 17, 2021
eskimor
approved these changes
Feb 17, 2021
pepyakin
approved these changes
Feb 17, 2021
| if !state.collations.contains_key(&relay_parent) || !should_advertise { | ||
| return; | ||
| match (state.collations.get_mut(&relay_parent), should_advertise) { | ||
| (None, _) | (_, false) => return, |
Contributor
There was a problem hiding this comment.
Nit: Could we spread these arms with a trace why we exit? This could give us a clue why a collation wasn't advertised
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
Member
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr changes the collator protocol to track the status of a
collation. This is mainly used to log the status of a collation when it
is removed to inform the user if a collation maybe never reached a validator.