Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Unused variable can be ignored#2381

Merged
bkchr merged 5 commits intoparitytech:masterfrom
saki-osive:master
Feb 4, 2021
Merged

Unused variable can be ignored#2381
bkchr merged 5 commits intoparitytech:masterfrom
saki-osive:master

Conversation

@saki-osive
Copy link
Contributor

@saki-osive saki-osive commented Feb 4, 2021

The request_multiplexer at

polkadot/node/service/src/lib.rs

Line 352 in 4866f8e

request_multiplexer: (),
can be ignored at compile-time, as it's not used anywhere.

@ordian ordian added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 4, 2021
@bkchr bkchr merged commit 76f867e into paritytech:master Feb 4, 2021
ordian added a commit that referenced this pull request Feb 4, 2021
@ordian
merge master
b1268aa 
* master:
  Unused variable can be ignored (#2381)
  End multiplexer stream once one of its inputs end. (#2380)
  Cargo build step needs pre requisites not mentioned (#2379)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saki-osive @ordian @bkchr

Comments