This repository was archived by the owner on Nov 15, 2023. It is now read-only.
guide: more robust approval counting procedure#2378
Merged
Conversation
rphmeier
added
A0-please_review
burdges
reviewed
Feb 5, 2021
burdges
reviewed
Feb 5, 2021
burdges
reviewed
Feb 5, 2021
roadmap/implementers-guide/src/node/approval/approval-voting.md
Outdated
Show resolved
Hide resolved
Contributor
|
It looks correct, just one example sentence I'd trouble parsing properly. |
ordian
added a commit
that referenced
this pull request
Feb 11, 2021
* master: Implement Approval Voting Subsystem (#2112) Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420) [CI] Move check_labels to github actions (#2415) runtime: set equivocation report longevity (#2404) Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331) Corrected Physical (#2414) validator_discovery: cache by (Hash, ParaId) (#2402) Enable wasmtime caching for PVF (companion for #8057) (#2387) Use construct_runtime in tests, remove default PalletInfo impl (#2409) validator_discovery: pass PeerSet to the request (#2372) guide: more robust approval counting procedure (#2378) Publish rococo on every push to `rococo-v1` branch (#2388) Bump trie-db from 0.22.2 to 0.22.3 (#2344) Send view to new peers (#2392)
ordian
added a commit
that referenced
this pull request
Feb 11, 2021
* master: Implement Approval Voting Subsystem (#2112) Introduce PerPeerSet utility that allows to segrate based on PeerSet (#2420) [CI] Move check_labels to github actions (#2415) runtime: set equivocation report longevity (#2404) Companion for #7936: Migrate pallet-balances to pallet attribute macro (#2331) Corrected Physical (#2414) validator_discovery: cache by (Hash, ParaId) (#2402) Enable wasmtime caching for PVF (companion for #8057) (#2387) Use construct_runtime in tests, remove default PalletInfo impl (#2409) validator_discovery: pass PeerSet to the request (#2372) guide: more robust approval counting procedure (#2378) Publish rococo on every push to `rococo-v1` branch (#2388) Bump trie-db from 0.22.2 to 0.22.3 (#2344) Send view to new peers (#2392)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on review from @burdges on #1975 and subsequent conversation.
There was an attack vector where malicious validators could broadcast early for tranches e.g. 2, 3, 4 and then DoS tranche 0 validators, making them perceived as no-shows. And then take over all the slots and approve something bad.