This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Approval Voting Database #2162
Merged
Merged
Approval Voting Database #2162
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
21d108e
skeleton
rphmeier 7c0a083
skeleton aux-schema module
rphmeier f1308f0
start approval types
rphmeier 6a6c5c0
start aux schema with aux store
rphmeier 7173066
doc
rphmeier 006dfa7
finish basic types
rphmeier 557b518
start approval types
rphmeier dc55799
doc
rphmeier fe79b4f
finish basic types
rphmeier e772603
Merge branch 'master' into rh-approval-types
rphmeier 8c0cef1
write out schema types
rphmeier 5ec3cfb
add debug and codec impls to approval types
rphmeier f415724
add debug and codec impls to approval types
rphmeier 1088ec3
add debug and codec impls to approval types
rphmeier 3ce7414
getters for block and candidate entries
rphmeier c9af5a0
grumbles
rphmeier 65f9fed
remove unused AssignmentId
rphmeier 321d43b
Merge branch 'rh-approval-types' into rh-approval-voting
rphmeier 910982a
load_decode utility
rphmeier 76bcfac
implement DB clearing
rphmeier 9a04615
function for adding new block entry to aux store
rphmeier bc6dcc2
start `canonicalize` implementation
rphmeier 834d776
more skeleton
rphmeier 31e840e
Merge branch 'master' into rh-approval-voting
rphmeier 5d1fafb
Merge branch 'master' into rh-approval-voting
rphmeier aebfecc
finish implementing canonicalize
rphmeier 7faa0c3
tag TODO
rphmeier 4a49ffb
implement a test AuxStore
rphmeier 0f1a8d6
add allow(unused)
rphmeier f7d7c49
basic loading and deleting test
rphmeier 0d384f7
block_entry test function
rphmeier b07f7a9
add a test for `add_block_entry`
rphmeier ec798fb
ensure range is exclusive at end
rphmeier 10613b4
test clear()
rphmeier bbe4b0c
test that add_block sets children
rphmeier a13d54c
add a test for canonicalize
rphmeier e336e45
Update node/core/approval-voting/src/aux_schema/mod.rs
rphmeier 69fb1b4
Update node/core/approval-voting/src/aux_schema/tests.rs
rphmeier 1e4be6e
Update node/core/approval-voting/src/aux_schema/mod.rs
rphmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| [package] | ||
| name = "polkadot-node-core-approval-voting" | ||
| version = "0.1.0" | ||
| authors = ["Parity Technologies <admin@parity.io>"] | ||
| edition = "2018" | ||
|
|
||
| [dependencies] | ||
| futures = "0.3.8" | ||
| parity-scale-codec = { version = "1.3.5", default-features = false, features = ["bit-vec", "derive"] } | ||
|
|
||
| polkadot-subsystem = { package = "polkadot-node-subsystem", path = "../../subsystem" } | ||
| polkadot-overseer = { path = "../../overseer" } | ||
| polkadot-primitives = { path = "../../../primitives" } | ||
| polkadot-node-primitives = { path = "../../primitives" } | ||
| bitvec = "0.17.4" | ||
|
|
||
| sc-client-api = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false } | ||
| sp-consensus-slots = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false } | ||
| sp-blockchain = { git = "https://github.com/paritytech/substrate", branch = "master", default-features = false } | ||
|
|
||
| [dev-dependencies] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: text files should have trailing newlines. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: bitvec should go among the external dependencies, not among the polkadot dependencies.