This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Closed
Conversation
gui1117
added
B0-silent
bkchr
approved these changes
Nov 30, 2020
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
This is not yet used anywhere, so we don't need any migrations! :)
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
gui1117
added
A2-insubstantial
Contributor
Author
|
then I'll close this one and do the rename directly in the Trait to Config PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rename the storage
Configin Configuration pallet toActiveConfig.This is to prevent name collision with incoming renaming of
TraitintoConfig.I think this pallet is used in some tests chains, thus I implemented the migration. Note that I don't think the migration needs any version check and bump because it only needs to migrate a value whenever it exist.
related: #2014