Conversation
|
Haven't noticed any anomalies in the metrics. |
mxinden
left a comment
There was a problem hiding this comment.
Thanks for doing this @ordian!
For what my review is worth, the changes look good to me, apart from the question below. Given my low involvement in the Polkadot code base and the size of this change, I would very much appreciate more eyes on this pull request.
Haven't noticed any anomalies in the metrics.
Same here. This has been running on a sentry node (kusama-sentry-ew4-0) for more than 5 days. Before merging, I would recommend running it on a validator as well. What do you think @ordian?
|
|
||
| sp-core = { package = "sp-core", git = "https://github.com/paritytech/substrate", branch = "master" } | ||
| parity-scale-codec = { version = "1.3.0", default-features = false, features = ["bit-vec", "derive"] } | ||
| parity-scale-codec = { version = "1.3.5", default-features = false, features = ["bit-vec", "derive"], package = "parity-scale-codec" } |
There was a problem hiding this comment.
If I understand package correctly, one can use it to rename dependencies. Why is it needed here, given that it does not rename the import variable, but instead just repeats the name?
There was a problem hiding this comment.
This was a bug in cargo-edit tool that I used to automatically bump all the dependencies. Reverted this change manually for futures in 3d16db4, thanks for catching this for parity-scale-codec, will fix now.
|
Addressed the renaming for Note that this PR doesn't upgrade dependencies constrained by sub-dependencies, like |
I don't think a validator burn-in is necessary here, but don't have a strong opinion either. |
mxinden
left a comment
There was a problem hiding this comment.
For what my review is worth, this looks good to me.
The update was done via
cargo upgrade --workspaceand then a couple of updates were reverted:bitvecrequires update fromparity-scale-codecshared_memoryupdate is more involved (seems to be split into https://github.com/elast0ny/raw_sync-rs)tokio0.3 was reverted to 0.2, require update from substratetiny-keccakwas updated manuallyas mentioned in paritytech/substrate#7509 (comment), it would be nice to do a burnin.