This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fixes bug that collator wasn't sending Declare message
#1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
A0-please_review
montekki
approved these changes
Nov 1, 2020
Contributor
montekki
left a comment
montekki
left a comment
There was a problem hiding this comment.
LGTM minus debug prints
node/network/bridge/src/lib.rs
Outdated
| }; | ||
|
|
||
| Ok(NetworkAction::WriteNotification(peer, peer_set, message)) | ||
| Ok(NetworkAction::WriteNotification(peer, dbg!(peer_set), message)) |
node/network/bridge/src/lib.rs
Outdated
Comment on lines
618
to
620
| peers, | ||
| dbg!(peers), | ||
| PeerSet::Collation, | ||
| WireMessage::ProtocolMessage(msg), | ||
| dbg!(WireMessage::ProtocolMessage(msg)), |
| // it should be handled here. | ||
| } | ||
| PeerViewChange(peer_id, view) => { | ||
| println!("PEERVIEWCHANGE: {:?} {:?}", peer_id, view); |
bkchr
commented
Nov 1, 2020
I'm an idiot
Contributor
|
bot merge |
|
Missing process info; check that the PR belongs to a project column. Merge can be attempted if:
See https://github.com/paritytech/parity-processbot#faq |
ordian
added a commit
that referenced
this pull request
Nov 2, 2020
* master: Adder collator improvements (#1896) Fixes bug that collator wasn't sending `Declare` message (#1895) fix service build: enable notifications protocol only under real overseer (#1894) Adds test parachain adder collator (#1864) A real overseer feature (#1892) Implementer's guide: Approval Voting Subsystem (#1691) Companion for #6912 (#1784)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.