This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
s3krit
added
A0-please_review
s3krit
force-pushed
the
mp-parity-srtool
branch
from
bf3fa18 to
34e5497
Compare
bkchr
approved these changes
Oct 29, 2020
s3krit
added a commit
that referenced
this pull request
Oct 30, 2020
* switch to using paritytech/srtool * update release link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we use chevdor's srtool, which is mostly fine. However, due to its use of phusion as its base image, it doesn't meet our Docker images maintenance policy.
In addition, due to its older version of nightly, chevdor/srtool doesn't currently seem to be able to build our Wasm blobs.
This works towards resolving paritytech/devops#618