Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Downward Message Processing implementation#1859

Merged
7 commits merged intomasterfrom
ser-dmp
Oct 28, 2020
Merged

Downward Message Processing implementation#1859
7 commits merged intomasterfrom
ser-dmp

Conversation

@pepyakin
Copy link
Copy Markdown
Contributor

Split off from #1679
Closes #1678
Related to #1806

Note that this change:

  • includes updates of XCM, but doesn't include the changes The Router Module #1679. The current plan is to land the guide changes together.
  • the last commit from The Router Module #1679 was split from the HRMP part and properly implemented.
  • I didn't address the suggestion of @coriolinus since I don't feel the discussion is over. I think it is better to continue it here if my arguments are not conviencing or if there are better suggestions.

@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 27, 2020
@pepyakin pepyakin mentioned this pull request Oct 27, 2020
2 tasks
Copy link
Copy Markdown
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the bikeshed up to you and @coriolinus

@coriolinus
Copy link
Copy Markdown
Contributor

if I am coding some stuff that works with the downward messages, what should I take: downward message or a downward message contents?

I guess it depends what you want to do with it. To me, if you have DownwardMessage and DownwardMessageContents, then the implication is that the former wraps and possibly extends the latter.

That said, I don't want to hold anything up with bikeshedding; if you feel that the current naming scheme is better, then just go ahead with it as it is.

@pepyakin
Copy link
Copy Markdown
Contributor Author

ok, then I am going to go ahead and merge. Although I'll try to keep this issue in mind when writing the client code.

@pepyakin
Copy link
Copy Markdown
Contributor Author

bot merge

@ghost
Copy link
Copy Markdown

ghost commented Oct 28, 2020

Trying merge.

@ghost ghost merged commit ed759c7 into master Oct 28, 2020
@ghost ghost deleted the ser-dmp branch October 28, 2020 10:41
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement DMP

4 participants