This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Downward Message Processing implementation#1859
Merged
Conversation
DMP: Integrate DMP parts into the inclusion module
rphmeier
approved these changes
Oct 27, 2020
Contributor
rphmeier
left a comment
There was a problem hiding this comment.
I'll leave the bikeshed up to you and @coriolinus
Contributor
I guess it depends what you want to do with it. To me, if you have That said, I don't want to hold anything up with bikeshedding; if you feel that the current naming scheme is better, then just go ahead with it as it is. |
Contributor
Author
|
ok, then I am going to go ahead and merge. Although I'll try to keep this issue in mind when writing the client code. |
Contributor
Author
|
bot merge |
|
Trying merge. |
This was referenced Oct 28, 2020
Merged
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #1679
Closes #1678
Related to #1806
Note that this change: