Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for #7247 (incremental priority group updates)#1800

Merged
4 commits merged intomasterfrom
ao-companion-7247-incremental-priority-group-updates
Oct 9, 2020
Merged

Companion PR for #7247 (incremental priority group updates)#1800
4 commits merged intomasterfrom
ao-companion-7247-incremental-priority-group-updates

Conversation

@ordian
Copy link

@ordian ordian commented Oct 9, 2020

@ordian ordian added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Oct 9, 2020
@tomaka
Copy link
Contributor

tomaka commented Oct 9, 2020

I'd suggest to change the methods on Network to take &mut self rather than &self. As long as you don't actually need multiple tasks to access to the network at the same time, having &mut self is a strictly better solution.

@ghost
Copy link

ghost commented Oct 9, 2020

Waiting for commit status.

@ghost ghost merged commit 0dc1fcd into master Oct 9, 2020
@ghost ghost deleted the ao-companion-7247-incremental-priority-group-updates branch October 9, 2020 14:34
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetworkBridge: use incremental priority_group updates

2 participants