This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
pepyakin
added
B0-silent
montekki
approved these changes
Oct 5, 2020
bkchr
approved these changes
Oct 5, 2020
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 6, 2020
* master: NetworkBridge: validator (authorities) discovery api (#1699) Registrar v1 follow-ups (#1786) Make collation an optional return (#1787) XCM: Land xcm-handler and xcm-executor (#1771) v0.8.25 (#1785) add two node local net script (#1781) Adjust max nominators down to 128 (from 256) (#1782) Companion for substrate/pull/7215 (#1768) Remove Stale Upgrades (#1780) Update Polkadot Weights for Substrate 2.0 (#1761)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to recently merged #1559
This PR comprised of two changes:
polkadot-runtime-parachains::Origintopolkadot-runtime-parachains::paras::Origin.schedule_para_cleanupfor the router module as well.Re: origin. TBH, I am not sure why it was made this way, but I don't see a reason why we should not use the original declaration directly. Otherwise, it spawns questions like: why do we add this origin into the mock but not into the runtime, are there any edge-cases if you register the essentially the same origin twice but using different paths, and so on.
I actually made it this way first in #1679, but failed to land the mock part in #1749.
Re:
schedule_para_cleanup. Right now, you are expected to call allschedule_para_cleanup. I don't remember the reasons why we decided to go with additional function instead of introducing a single entrypoint (i.e. call the router module from paras) or introducing another top-level entrypoint, but this PR might be a sign that we might need to reconsider this. Although I don't think it's critical though. cc @rphmeierThis PR was split from #1679