This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
Seems like that was missed during the transition from notions of global and local validation data to persistent and transient
this allows us to avoid piling Error and Result types from different contexts, specifically std vs. module-local
pepyakin
added
A0-please_review
ordian
approved these changes
Sep 25, 2020
ordian
added
A8-mergeoncegreen
and removed
A0-please_review
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Sep 28, 2020
* master: Collator protocol followup (#1741) Revert "Remove Old Service, 2nd try (#1732)" (#1758) Remove Old Service, 2nd try (#1732) collation-generation: guide and tidying (#1753) Companion for #7111 (Introduce `cancel_proposal` and `blacklist`) (#1728) Parachains: Introduce a dummy module to include the Origin. (#1749) provisioner tests: remove tokio from dev-dependencies (#1745)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit.
i noticed these things during my work on #1679