This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Implementer's Guide: Allow the watermark to always land on the relay parent#1689
Merged
1 commit merged intomasterfrom Sep 10, 2020
Merged
Implementer's Guide: Allow the watermark to always land on the relay parent#16891 commit merged intomasterfrom
1 commit merged intomasterfrom
Conversation
pepyakin
added
B0-silent
drahnr
approved these changes
Sep 8, 2020
Contributor
Author
|
bot merge |
|
Checks failed; merge aborted. |
pepyakin
force-pushed
the
ser-watermark-no-pending
branch
from
bd51237 to
cb6a5dc
Compare
Contributor
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
Contributor
|
It's not impossible we'd want this to be the block before the relay parent or even further, and to forbid reading messages further ahead than this limit. It'd address the pipelined version of the bug this OPR fixes: You could be blocked because you needed to advance your watermark, but you cannot obtain them message yet. We'll see what shakes out, but I wanted to caution that acting upon messages too fast could create problems. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1671
The HRMP watermark can now land not only on an entry in the digest but also on the relay-parent block.
First, it fixes a problem that there is no way to satisfy the following two rules if there is no pending messages
Implication of these changes is that the watermark now can point on a block where no messages were sent to the para (i.e. no entry in digest). Don't see why this could be a problem.