This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Support build-spec for other chains than Polkadot#1567
Merged
Conversation
The problem when building a chain specification is that you require the native runtime to parse the json file (assuming the chain spec is not raw yet). Before this pr we could only overwrite the native runtime when running the node using `force_*`. This pr now adds support to load the native runtime when the filename starts with the name of the chain. So, when usng `build-spec --chain rococo-something-else.jon` it will use the rococo native runtime to load the chain spec.
bkchr
added
A0-please_review
riusricardo
approved these changes
Aug 11, 2020
Contributor
riusricardo
left a comment
riusricardo
left a comment
There was a problem hiding this comment.
👍 It fixes the issue.
ordian
reviewed
Aug 11, 2020
bkchr
commented
Aug 11, 2020
Co-authored-by: Andronik Ordian <write@reusable.software>
ordian
added
A8-mergeoncegreen
and removed
A0-please_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem when building a chain specification is that you require the
native runtime to parse the json file (assuming the chain spec is not
raw yet). Before this pr we could only overwrite the native runtime when
running the node using
force_*. This pr now adds support to load thenative runtime when the filename starts with the name of the chain. So,
when usng
build-spec --chain rococo-something-else.jonit will use therococo native runtime to load the chain spec.
Fixes: #1565