This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update .editorconfig to what we have in practice#1545
Merged
Conversation
pepyakin
added
A2-insubstantial
While editing the impl guide markdowns I tried to be inline with what seemingly more common way to indent them: spaces. However, despite that I changed it kept reseting. Turned out the culprit is the .editorconfig file. This commit addresses this issue. I didn't try to deduplicate the rules since I found that the formal specification is a bit ambigious and it is not a big deal anyway.
pepyakin
force-pushed
the
ser-editorconfig
branch
from
578c863 to
c60f8b8
Compare
coriolinus
approved these changes
Aug 6, 2020
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Seems fine to me, but I'm somewhat surprised that you mention in the description that the motivating incident involved markdown files, but you didn't add a *.md section to the file.
Contributor
Author
|
me: creates a PR for .editorconfig that stayed in its original form for 2 years straight.
Ah yeah that's confusing, sorry. My motivation was to improve the status quo by deregulating how the *.md files are formatted. I didn't risk to add actual rules for the *.md to not spark a bikeshed discussion and removing all discrepancies that will arise from that. |
ekrem95
approved these changes
Aug 7, 2020
ordian
added a commit
that referenced
this pull request
Aug 14, 2020
* master: Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
ordian
added a commit
that referenced
this pull request
Aug 17, 2020
* master: overseer: fix build (#1596) Companion PR for #6862 (#1564) implement collation generation subsystem (#1557) Add spawn_blocking to SubsystemContext (#1570) Companion PR for #6846 (#1568) overseer: add a test to ensure all subsystem receive msgs (#1590) Implementer's Guide: Flesh out more details for upward messages (#1556) Make parachain validation wasm executor functional (#1574) Use async test helper to simplify node testing (#1578) guide: validation data refactoring (#1576) Remove v0 parachains runtime (#1501) [CI] Add github token to generate-release-text (#1581) Allow using any polkadot client instead of enum Client (#1575) service/src/lib: Update authority discovery construction (#1563) Update .editorconfig to what we have in practice (#1545) Companion PR for substrate #6672 (#1560) pre-redenomination tockenSymbol change (#1561)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While editing the impl guide markdowns I tried to be inline with what seemingly more
common way to indent them: spaces. However, despite that I changed it kept reseting.
Turned out the culprit is the .editorconfig file.
This commit addresses this issue. I didn't try to deduplicate the rules since
I found that the formal specification is a bit ambigious and it is not a big
deal anyway.