This repository was archived by the owner on Nov 15, 2023. It is now read-only.
*: Enable authority discovery by default#1395
Merged
Conversation
Instead of having to explicitly enable the authority discovery module on validator and sentry nodes, this commit enables the module by default. Today there is no way for non validator or sentry nodes to run the module. That might change in the future.
mxinden
added
A0-please_review
tomaka
added
C3-medium
tomaka
approved these changes
Jul 13, 2020
Contributor
|
(tests are failing, in case you haven't noticed) |
Contributor
|
cc @ddorgan |
Member
|
@tomaka thanks for the heads up! |
rphmeier
approved these changes
Jul 13, 2020
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having to explicitly enable the authority discovery module on
validator and sentry nodes, this commit enables the module by default.
Today there is no way for non validator or sentry nodes to run the
module. That might change in the future.
Closes #1392