Closed
Conversation
Implemented ERC721 XCM transactor (not yet tested end-to-end).
Imported IERC721 standard via alloy_core::sol!("src/IERC721.sol").
Added ERC721 fixture contracts compiled for PolkaVM.
Created tests that deploy and interact with the ERC721 contracts in impl_nonfungibles
|
User @aleGiannini, please sign the CLA here. |
aleGiannini
commented
Sep 28, 2025
| pub const ERC721TransferGasLimit: Weight = Weight::from_parts(1_000_000_000, 200_000); | ||
| pub const ERC721TransferStorageDepositLimit: Balance = 25_000_000_000; | ||
| pub ERC721TransfersCheckingAccount: AccountId = PalletId(*b"py/revch").into_account_truncating(); | ||
| } |
Author
There was a problem hiding this comment.
In the withdraw tests the gas_consumed was ≈ 881M and storage_deposit ≈ 20B.
In the deposit tests the gas_consumed was ≈ 881M and storage_deposit ≈ 10B.
I setted the gas limit at 1B and the storage deposit limit at 25B.
@franciscoaguirre Could this be correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #7523
As with the Erc20AssetTransactor implementation #7762 , I implemented the equivalent for ERC-721, including test smart contracts; I also added a nonfungibles::* implementation useful for inspection and minting in tests.